Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44534 )
Change subject: soc/amd/common: add gpio subsystem event reporting ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44534/5/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/44534/5/src/soc/amd/common/block/gp... PS5, Line 352: control_switch
I added that because the PPR isn't clear on what bit is blocking the other registers. […]
Yeah, I had similar things in mind. I agree that having the information printed out would be helpful when hardware is doing odd things. I just wanted to make sure that it wasn't a miss that the control switch isn't checked anywhere. I think what we have in this patchset looks good.