Attention is currently required from: David Wu, Karthik Ramasubramanian, Morris Hsu, Ren Kuo.
Tyler Wang has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84002?usp=email )
Change subject: mb/google/brox/var/jubilant: Enable devices on unprovisioned fw_config
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84002/comment/ae451a09_5a87e6d3?usp... :
PS2, Line 11: fw-config
fw_config?
File src/mainboard/google/brox/variants/jubilant/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84002/comment/7521680b_d982ef77?usp... :
PS2, Line 235: unprovisioned
Have you define "UNPROVISIONED"? I didn't saw it in overridetree.cb.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84002?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia14632744c34548e2c201dfc58d82515cdd02df0
Gerrit-Change-Number: 84002
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Morris Hsu
morris-hsu@quanta.corp-partner.google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Morris Hsu
morris-hsu@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 21 Aug 2024 08:39:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No