[coreboot-gerrit] [XS] Change in coreboot[main]: soc/mediatek/mt8196: Set SPMI-P SCL/SDA pins to pull-down

[Jarried Lin (Code Review)]

Attention is currently required from: Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu.

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85751?usp=email )

Change subject: soc/mediatek/mt8196: Set SPMI-P SCL/SDA pins to pull-down
......................................................................

Patch Set 9:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85751/comment/a8920187_4afbd566?usp... :
PS8, Line 7: SoC PD
> pins to pull-down.

Done

https://review.coreboot.org/c/coreboot/+/85751/comment/21ddd374_696f3585?usp... :
PS8, Line 9: ,
> SoC side.

Done

https://review.coreboot.org/c/coreboot/+/85751/comment/0a058da8_5c29e055?usp... :
PS8, Line 10: it is done only once during the SPMI read check to fix SPMI clock
            : calibration failure.
> Can you explain why ?

Done

File src/soc/mediatek/mt8196/pmif_spmi.c:

https://review.coreboot.org/c/coreboot/+/85751/comment/5a301315_0ebab124?usp... :
PS8, Line 170: 	/* SPMI-P set Pull-Down mode*/
> Space after "mode"

Done