Attention is currently required from: Malik Hsu. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59367 )
Change subject: mb/google/brya/variants/primus: add fw_config_probe for ALC5682I-VS ......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/brya/variants/primus/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59367/comment/9c2ec727_714fab42 PS4, Line 188: end should there be another probe statement here too?
``` probe AUDIO MAX98360_ALC5682I_VS_I2S ``` ?
File src/mainboard/google/brya/variants/primus/variant.c:
https://review.coreboot.org/c/coreboot/+/59367/comment/8f282c27_2ba420a4 PS4, Line 28: audio_codec->enabled = 1; if you add the probe statement to the devicetree, you don't need this here