nickey.yang@rock-chips.com has posted comments on this change. ( https://review.coreboot.org/19477 )
Change subject: rockchip/rk3399: Add MIPI driver ......................................................................
Patch Set 5:
(7 comments)
https://review.coreboot.org/#/c/19477/2/src/soc/rockchip/rk3399/mipi.c File src/soc/rockchip/rk3399/mipi.c:
Line 406: {
That doesn't require you to have this here, though. You can just put a
No verified on the 3288 platform with Mipi panel, so can we put it here first?
https://review.coreboot.org/#/c/19477/4/src/soc/rockchip/rk3399/mipi.c File src/soc/rockchip/rk3399/mipi.c:
PS4, Line 182:
target_bps should also be unsigned long, just in case. Also, I think it wou
Done
PS4, Line 183: target_bps
1500 * MHz
Done
PS4, Line 206: / n) <
5 * MHz and 40 * MHz
Done
PS4, Line 216: ak;
This should also be lane_bps instead and all subsequent calculations with i
Done
Line 405: void rk_mipi_prepare(const struct edid *edid)
Remove this and just do
Done
Line 436
I feel like I must have asked this somewhere already... where do the 500ms
Done