Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31310 )
Change subject: sb/intel/i82801gx/lpc: Use {read,write}_pmbase32 and lpc_get_pmbase
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31310/6/src/southbridge/intel/i82801gx/lpc.c
File src/southbridge/intel/i82801gx/lpc.c:
https://review.coreboot.org/#/c/31310/6/src/southbridge/intel/i82801gx/lpc.c...
PS6, Line 264: /* Set up power management block and determine sleep mode */
pmbase is no longer used an can be removed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31310
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00bd687c487894c72d4e4363774dbcdfaf62dd54
Gerrit-Change-Number: 31310
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 13 Apr 2019 16:31:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment