Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38003 )
Change subject: mainboard/google/puff: Enable net driver on pcie ep ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38003/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38003/3//COMMIT_MSG@7 PS3, Line 7: mainboard/google/puff: Enable net driver on pcie ep AFAICT, the driver is already enabled for puff, so that part is a no=op for puff.
The functional part of this patch is the devicetree part that sets up the LEDs and enables device 0.0; so I recommend changing the commit message subject to reflect that.
Further, so as to unblock this important change, move the KConfig part that enables the NIC driver for all hatch to a different CL which can have its own discussion.