Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83989?usp=email )
Change subject: soc/mediatek: Move SNFC pad_func into MediaTek common directory ......................................................................
Patch Set 3:
(5 comments)
File src/soc/mediatek/common/include/soc/snfc.h:
PS1: move to flash_controller_common.h
File src/soc/mediatek/common/snfc.c:
https://review.coreboot.org/c/coreboot/+/83989/comment/14de6e62_6a6b3176?usp... : PS1, Line 9: uint8_t drive_strength enum gpio_drv strength
https://review.coreboot.org/c/coreboot/+/83989/comment/9fac4555_601fbfa4?usp... : PS1, Line 17: 14 It seems to me that we can convert `enum gpio_drv` into `mA` by `(drive_strength + 1) * 2`.
https://review.coreboot.org/c/coreboot/+/83989/comment/792b3397_0b1c8a81?usp... : PS1, Line 8: : void mtk_snfc_init_pad_func(const struct pad_func *pad_func, uint8_t drive_strength) : { : : gpio_set_pull(pad_func->gpio, GPIO_PULL_ENABLE, pad_func->select); : gpio_set_mode(pad_func->gpio, pad_func->func); : : if (gpio_set_driving(pad_func->gpio, drive_strength) < 0) : printk(BIOS_ERR, : "%s: failed to set pin drive to 14 mA for %d\n", : __func__, pad_func->gpio.id); : else : printk(BIOS_DEBUG, "%s: got pin drive: %#x\n", __func__, : gpio_get_driving(pad_func->gpio)); : } what about moving this function to flash_controller.c
https://review.coreboot.org/c/coreboot/+/83989/comment/5e1415fb_cab512f8?usp... : PS1, Line 23: remove blank lines