[coreboot-gerrit] Change in coreboot[master]: driver/intel/fsp2_0: Disable NULL deref code on some FSP

[Lean Sheng Tan (Code Review)]

Attention is currently required from: Mario Scheithauer, Arthur Heymans, Andrey Petrov.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64426 )

Change subject: driver/intel/fsp2_0: Disable NULL deref code on some FSP
......................................................................

Patch Set 3:

(1 comment)

File src/drivers/intel/fsp2_0/memory_init.c:

https://review.coreboot.org/c/coreboot/+/64426/comment/a545d77c_78682a45 
PS2, Line 297: 	if (CONFIG(FSP_ACCESSES_NULL_WORKAROUND))
             : 		null_breakpoint_disable();
             : 	post_code(POST_FSP_MEMORY_INIT);
             : 	timestamp_add_now(TS_FSP_MEMORY_INIT_START);
             : 	if (ENV_X86_64 && CONFIG(PLATFORM_USES_FSP2_X86_32))
             : 		status = protected_mode_call_2arg(fsp_raminit,
             : 						  (uintptr_t)&fspm_upd,
             : 						  (uintptr_t)fsp_get_hob_list_ptr());
             : 	else
             : 		status = fsp_raminit(&fspm_upd, fsp_get_hob_list_ptr());
             : 	if (CONFIG(FSP_ACCESSES_NULL_WORKAROUND))
             : 		null_breakpoint_init();
             :
> Can you please implement this for silicon init (silicon_init.c) as well? […]

Hi Mario, I also saw the same issue on ADL, with the latest patch the issue should fix now. Could you try?