Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31887 )
Change subject: vboot: make vboot_working_data available to payload ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31887/1/payloads/libpayload/libc/coreboot.c File payloads/libpayload/libc/coreboot.c:
https://review.coreboot.org/#/c/31887/1/payloads/libpayload/libc/coreboot.c@... PS1, Line 93: info->vboot_wd = (void *)(uintptr_t)vbwd->range_start; I'm starting to wonder if we *should* just pass vb2_shared_data + workbuf only, and use lb_range's range_size to store the size of vb2_shared_data + workbuf...
That would certainly simplify not requiring us to expose vboot_working_data to libpayload, and also simplify the code to read the pointer on the other end (in depthcharge).