Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63729 )
Change subject: soc/amd/sabrina/psp_verstage: Unify SVC ID
......................................................................
Patch Set 2:
(2 comments)
File src/soc/amd/sabrina/psp_verstage/svc.h:
https://review.coreboot.org/c/coreboot/+/63729/comment/15526ea5_a6a92f8f
PS1, Line 144:
Do we have post codes?
Not in the first set of sub-commands being supported. I will bring that up with PSP team for their visibility.
File src/vendorcode/amd/fsp/sabrina/include/bl_uapp/bl_syscall_public.h:
https://review.coreboot.org/c/coreboot/+/63729/comment/f55b3091_3ecec3a2
PS1, Line 150: PRODUCTION
Can we rename this to NORMAL? It matches the vboot naming.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63729
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56be51aa1dfb00e5f0945014600de2bbbec289db
Gerrit-Change-Number: 63729
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Avinash Alevoor
Gerrit-CC: Mohan Viswanathan
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 21 Apr 2022 22:29:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment