Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33377 )
Change subject: mb/google/octopus: Add API to disable USB devices
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/33377/4/src/soc/intel/common/block/...
File src/soc/intel/common/block/xhci/xhci.c:
https://review.coreboot.org/c/coreboot/+/33377/4/src/soc/intel/common/block/...
PS4, Line 99: ext_usb_xhci_en_cb
Do you think there is value in allowing mainboard to pass in a NULL for this so that all external ports are assumed to be enabled?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33377
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied12faabee1b8c096f2b27de89ab42ee8be5d94d
Gerrit-Change-Number: 33377
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 17 Jul 2019 06:06:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment