Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43783 )
Change subject: amd/picasso: rework USB2 PHY tune parameter handling
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43783/4/src/soc/amd/picasso/chip.h
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/43783/4/src/soc/amd/picasso/chip.h@...
PS4, Line 139: USB_PORT_COUNT
Just curious: Can't we directly use `FSPS_UPD_USB2_PORT_COUNT` here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67f23c0602e345fbd806e661a4462cf07f93ef64
Gerrit-Change-Number: 43783
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 25 Jul 2020 04:57:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment