23 Aug
2024
23 Aug
'24
4:34 a.m.
Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83923?usp=email )
Change subject: soc/mediatek/mt8196: Add NOR-Flash support ......................................................................
Patch Set 11:
(1 comment)
File src/soc/mediatek/mt8196/spi.c:
https://review.coreboot.org/c/coreboot/+/83923/comment/f6dd4bc1_3e3e5292?usp... : PS11, Line 18: /* GPIO 91,92,101,102 */ (Optional) Consider removing the comment, as they're already defined in gpio.h.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83923?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id0a19f0520020f16c4cf9d62da4228a5b0371b91
Gerrit-Change-Number: 83923
Gerrit-PatchSet: 11
Gerrit-Owner: Jarried Lin jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 23 Aug 2024 02:34:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No