Attention is currently required from: V sujith kumar Reddy, Yu-hsuan Hsu. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60072 )
Change subject: Passing EN_SPKR gpio descriptor from coreboot to kernel ......................................................................
Patch Set 2: Code-Review+1
(6 comments)
File src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c:
https://review.coreboot.org/c/coreboot/+/60072/comment/b0672d4b_96fef59a PS2, Line 21: dmic_select_gpio So this function expected the dmic_select_gpio to always have pin_count > 0 since it was checked before calling it. Now that it's optional, we need to properly guard calling `acpi_device_write_gpio` and `acpi_dp_add_gpio`.
i.e., if (dmic_select_gpio->pin_count) acpi_device_write_gpio(dmic_select_gpio);
https://review.coreboot.org/c/coreboot/+/60072/comment/94439da0_63eb149f PS2, Line 35: acpi_dp_add_gpio This needs a guard too
https://review.coreboot.org/c/coreboot/+/60072/comment/d2fa31ce_a48361f6 PS2, Line 39: enspkr_gpio Should be `enspkr_gpio->pin_count`
https://review.coreboot.org/c/coreboot/+/60072/comment/e913798e_8f70866c PS2, Line 40: 1 This index will change depending if dmic-gpios is passed in.
File src/mainboard/google/guybrush/variants/baseboard/devicetree.cb:
PS2: Please split this into a separate file.
https://review.coreboot.org/c/coreboot/+/60072/comment/9049dd77_d8c7eef3 PS2, Line 328: GPIO_31 So this is true for `board id >= 2`: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
You will need to implement `variant_devtree_update`: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
Here is an example where the SD aux pin is different: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...