Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee...
PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */
Gotcha. […]
I just checked the VCM datasheet and I'd have to check the board and module schematics (would be nice if someone could point me to the right one for this board) for completeness, and AFAICT this VCM has neither any clock input nor any reset/power-on pins, so it should be enough to just control the power rails.
Otherwise the idea sounds good to me. Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45159
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968
Gerrit-Change-Number: 45159
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bingbu Cao
bingbu.cao@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tomasz Figa
tfiga@google.com
Gerrit-Comment-Date: Thu, 01 Oct 2020 14:55:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Tomasz Figa
tfiga@google.com
Gerrit-MessageType: comment