Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 6:
(3 comments)
Sorry for late response. I've just got back to this. Changed code to add reference check and etc. Also done with S0ix sanity check.
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */
Got it. […]
Sorry for late response. I've added reference counter (REFC). Also removed unnecessary steps in the VCM power up/down such as image clock on and off.
https://review.coreboot.org/c/coreboot/+/45159/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/5/src/mainboard/google/voltee... PS5, Line 347: If ((STA == Zero))
maybe If (STA == 0)
changed logic and this part is removed.
https://review.coreboot.org/c/coreboot/+/45159/5/src/mainboard/google/voltee... PS5, Line 370: Store(1,STA)
Please use ASL 2. […]
Done