24 Mar
2022
24 Mar
'22
12:21 a.m.
Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Paul Menzel, Zheng Bao, Elyes Haouas, Felix Held. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62750 )
Change subject: $top/Makefile.inc: Move common folder before other sibling ones ......................................................................
Patch Set 10: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62750/comment/27d7249d_91da1389 PS3, Line 13: The duplicated "common" in the result string can be eliminated finally.
The original intention is put folder common before others. […]
Hmm... right, okay, that's fair. Guess we'll go with this then.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62750
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99597af22cac6d12aaef348789664cd7db02ba06
Gerrit-Change-Number: 62750
Gerrit-PatchSet: 10
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Bao Zheng fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 23 Mar 2022 22:21:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Bao Zheng fishbaozi@gmail.com
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment