Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/19998 )
Change subject: cbfstool/lz4/lib/lz4frame.c: Don't fallthrough on case dstage_getHeader
......................................................................
Patch Set 3: Code-Review-1
https://github.com/lz4/lz4/blob/dev/lib/lz4frame.c#L1099 indicates that the fall through might be deliberate. maybe we should just update the library?
--
To view, visit
https://review.coreboot.org/19998
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2dcc0895cd5ea149425c1ae01fc1af70e3657e7
Gerrit-Change-Number: 19998
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philippe Mathieu-Daudé
philippe.mathieu.daude@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 02 Jun 2017 05:55:38 +0000
Gerrit-HasComments: No