Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Sridhar Siricilla. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63294 )
Change subject: mb/google/brya: Disable PCH USB2 phy power gating ......................................................................
Patch Set 4: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63294/comment/61d1215a_0b86849c PS1, Line 9: The patch disables PCH USB2 Phy power gating.
Added the motivation details.
Thanks. Fell free to mark these comments as resolved once you acted on them.
Commit Message:
https://review.coreboot.org/c/coreboot/+/63294/comment/64f47c08_3346550b PS4, Line 10: to prevent possible display flicker issue “possible” means it was never reproduced in practice and is theoretical, or it happens sometimes, and sometimes it does not?
https://review.coreboot.org/c/coreboot/+/63294/comment/f63b610b_223437b9 PS4, Line 9: The patch disables PCH USB2 Phy power gating. This change is required : to prevent possible display flicker issue. Shorter:
Disable PCH USB2 PHY power gating to prevent display flickering … (in the OS?).
File src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/63294/comment/e8fdf277_50f81ebd PS4, Line 25: # Disable PCH USB2 Phy power gating I see all the other entries have comments, but in this case the variable names are self-describing, so I’d remove the comment. I’d rather add the display flicker issue as a comment.