Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35235 )
Change subject: soc/intel/cannonlake: memory spd data debug
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35235/3/src/soc/intel/cannonlake/cn...
File src/soc/intel/cannonlake/cnl_memcfg_init.c:
https://review.coreboot.org/c/coreboot/+/35235/3/src/soc/intel/cannonlake/cn...
PS3, Line 115: last_spd_index = spd_index;
Wouldn't it be better to print here? If the same SPD is used for multiple slots, you would end up printing multiple times above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35235
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e257a8ea6ff9c906267841819d2a4b62a9e0b9e
Gerrit-Change-Number: 35235
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Sep 2019 15:51:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment