Attention is currently required from: Nico Huber, Martin Roth, Matt DeVillier, Andy Pont, Paul Menzel, Stefan Reinauer, Angel Pons.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56223 )
Change subject: payloads/external/tianocore: Add build argument for 4G Decode
......................................................................
Patch Set 22:
(1 comment)
File payloads/external/tianocore/Makefile:
https://review.coreboot.org/c/coreboot/+/56223/comment/f6ae5fb8_75a45860
PS21, Line 38: 4G=-D ABOVE_4G_DECODE=TRUE
: else
: 4G=-D ABOVE_4G_DECODE=FALSE
variable change to match Kconfig?
I guess we should. PR open to your branch to make it match.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56223
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3b1d15196c0ec611431af29031682fea626d19d
Gerrit-Change-Number: 56223
Gerrit-PatchSet: 22
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 18 Aug 2021 15:27:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment