Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34560 )
Change subject: soc/nvidia/tegra124: Correct bitwise operation ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34560/1/src/soc/nvidia/tegra124/sor... File src/soc/nvidia/tegra124/sor.c:
https://review.coreboot.org/c/coreboot/+/34560/1/src/soc/nvidia/tegra124/sor... PS1, Line 351: reg_val &= ~(APBDEV_PMC_IO_DPD2_REQ_LVDS_ON ||
That logical or is suspicious...
The previous &= clears the bits in positions 25, 30, and 31, and then the APBDEV constants in the next line set some of them. Using an &= for this line would clear the whole variable, while an |= re-enables some of those bits instead (that was my reasoning).