[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: config spk_en gpio to low by default

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41853 )

Change subject: mb/google/dedede: config spk_en gpio to low by default
......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/41853/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/41853/2/src/mainboard/google/dedede... 
PS2, Line 178: GPP_D17
> I think Furquan was referring to register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D17)" in […]

As mentioned by Usha, audio support for waddledee is yet to be added. The GPIO will be exposed through ACPI when the audio support gets added in waddledee. Even though the amplifier is different, the GPIO purpose is still the same i.e to enable the speaker.