9 Nov
2019
9 Nov
'19
8:05 a.m.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36662 )
Change subject: arch/x86: Correctly determine number of enabled cores ......................................................................
Patch Set 1: Code-Review-1
Reading the SMBIOS spec, this field seems explicitly designed to *not* reflect actual core count but rather whatever is configured by the firmware. So actually CONFIG_MAX_CPUS would be a better choice.
OTOH, maybe the CPUID result will reflect this anyway?
--
To view, visit https://review.coreboot.org/c/coreboot/+/36662
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0935f48e73c037bb7c0e1cf36f94d98a40a499c
Gerrit-Change-Number: 36662
Gerrit-PatchSet: 1
Gerrit-Owner: Andrey Petrov anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 09 Nov 2019 07:05:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment