Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31785 )
Change subject: soc/intel/braswell: Use IRQ 9 for SCI
......................................................................
Patch Set 1:
(1 comment)
SCI interrupt number must be configured.
https://review.coreboot.org/#/c/31785/1/src/soc/intel/braswell/southcluster....
File src/soc/intel/braswell/southcluster.c:
https://review.coreboot.org/#/c/31785/1/src/soc/intel/braswell/southcluster....
PS1, Line 281: write32((void *)(ilb_base + ACTL), 0);
This is the leftover from IO APIC initializaiton? Everythig else is already set by FSP?
Yes, FSP does not configure SCI interrupt.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31785
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09aca433528b6f64ad3ff3753ae8392c0d89cdc0
Gerrit-Change-Number: 31785
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Comment-Date: Mon, 18 Mar 2019 12:36:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment