Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42668 )
Change subject: sb/intel/i82801ix/fadt.c: Use acpi.h definitions ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42668/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/fadt.c:
https://review.coreboot.org/c/coreboot/+/42668/1/src/southbridge/intel/i8280... PS1, Line 70: fadt->x_pm1b_evt_blk.space_id = 0;
setting all fields to zero is valid in ACPI and marks it as unused. […]
I'm not sure if Kyösti has plans to handle this, but I agree that we probably want to drop this if fadt defaults to zero already. However, I'd rather handle this in a follow-up to avoid rebasing about two dozen changes that lie atop this one.