Attention is currently required from: Hung-Te Lin, Paul Menzel, Ryan Chuang, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60385 )
Change subject: soc/mediatek/mt8186: Add header files to support DRAM calibration
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
PS2:
IMO CB:60318 could be merged into this patch.
suggestion from:
https://review.coreboot.org/c/coreboot/+/60318/7..10//COMMIT_MSG#b10
File src/soc/mediatek/mt8186/include/soc/dramc_param.h:
https://review.coreboot.org/c/coreboot/+/60385/comment/8827d330_21a2d2f7
PS2, Line 59: struct dramc_param_header {
Okay, but please add the 'config' field here first. Otherwise there will be incompatible changes.
Done
https://review.coreboot.org/c/coreboot/+/60385/comment/46c1497b_adb06b32
PS2, Line 149: int validate_dramc_param(const void *blob);
: int is_valid_dramc_param(const void *blob);
These 2 don't exist in common/dramc_param.c, and they are not called either.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8662ed43088ea5aa1fe6cb5b2c4bda2338c4387
Gerrit-Change-Number: 60385
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Ryan Chuang
ryan.chuang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ryan Chuang
ryan.chuang@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 27 Dec 2021 08:30:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen
rex-bc.chen@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment