build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31501 )
Change subject: inteltool: coffeelake support ......................................................................
Patch Set 1:
(68 comments)
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c File util/inteltool/gpio_groups.c:
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@848 PS1, Line 848: "GPP_A0", "RCIN#", "n/a", "ESPI_ALERT1#", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@849 PS1, Line 849: "GPP_A1", "LAD0", "n/a", "ESPI_IO0", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@850 PS1, Line 850: "GPP_A2", "LAD1", "n/a", "ESPI_IO1", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@851 PS1, Line 851: "GPP_A3", "LAD2", "n/a", "ESPI_IO2", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@852 PS1, Line 852: "GPP_A4", "LAD3", "n/a", "ESPI_IO3", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@853 PS1, Line 853: "GPP_A5", "LFRAME#", "n/a", "ESPI_CS0#", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@854 PS1, Line 854: "GPP_A6", "SERIRQ", "n/a", "ESPI_CS1#", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@855 PS1, Line 855: "GPP_A7", "PIRQA#", "n/a", "ESPI_ALERT0#", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@856 PS1, Line 856: "GPP_A8", "CLKRUN#", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@857 PS1, Line 857: "GPP_A9", "CLKOUT_LPC0", "n/a", "ESPI_CLK", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@858 PS1, Line 858: "GPP_A10", "CLKOUT_LPC1", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@859 PS1, Line 859: "GPP_A11", "PME#", "SD_VDD_PWR_EN#", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@860 PS1, Line 860: "GPP_A12", "BM_BUSY#", "ISH_GP6", "SX_EXIT_HOLDOFF#", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@861 PS1, Line 861: "GPP_A13", "SUSWARN#/SUSPWRDNACK", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@862 PS1, Line 862: "GPP_A14", "SUS_STAT#", "n/a", "ESPI_RESET#", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@863 PS1, Line 863: "GPP_A15", "SUSACK#", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@864 PS1, Line 864: "GPP_A16", "CLKOUT_48", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@865 PS1, Line 865: "GPP_A17", "SD_VDD1_PWR_EN#", "ISH_GP7", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@866 PS1, Line 866: "GPP_A18", "ISH_GP0", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@867 PS1, Line 867: "GPP_A19", "ISH_GP1", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@868 PS1, Line 868: "GPP_A20", "ISH_GP2", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@869 PS1, Line 869: "GPP_A21", "ISH_GP3", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@870 PS1, Line 870: "GPP_A22", "ISH_GP4", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@871 PS1, Line 871: "GPP_A23", "ISH_GP5", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@952 PS1, Line 952: "GPP_D0", "SPI1_CS#", "n/a", "SBK0", "BK0", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@953 PS1, Line 953: "GPP_D1", "SPI1_CLK", "n/a", "SBK1", "BK1", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@954 PS1, Line 954: "GPP_D2", "SPI1_MISO", "n/a", "SBK2", "BK2", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@955 PS1, Line 955: "GPP_D3", "SPI2_MOSI", "n/a", "SBK3", "BK3", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@956 PS1, Line 956: "GPP_D4", "ISH_I2C2SDA", "I2C3_SDA", "SBK4", "BK4" line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@957 PS1, Line 957: "GPP_D5", "I2S2_SFRM", "n/a", "CNV_RF_RESET#", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@958 PS1, Line 958: "GPP_D6", "I2S2_TXD", "n/a", "modem_CLKREQ", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@959 PS1, Line 959: "GPP_D7", "I2S2_RXD", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@960 PS1, Line 960: "GPP_D8", "I2S2_SCLK", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@961 PS1, Line 961: "GPP_D9", "ISH_SPI_CS#", "n/a", "GSPI2_CS0#", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@962 PS1, Line 962: "GPP_D10", "ISH_SPI_CLK", "n/a", "GSPI2_CLK", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@963 PS1, Line 963: "GPP_D11", "ISH_SPI_MISO", "GP_BSSB_CLK", "GSPI2_MISO", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@964 PS1, Line 964: "GPP_D12", "ISH_SPI_MOSI", "GP_BSSB_DI", "GSPI2_MOSI", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@965 PS1, Line 965: "GPP_D13", "ISH_UART0_RXD", "n/a", "I2C2_SDA", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@966 PS1, Line 966: "GPP_D14", "ISH_UART0_TXD", "n/a", "I2C2_SCL", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@967 PS1, Line 967: "GPP_D15", "ISH_UART0_RTS#", "GSPI_CS1#", "n/a", "CNV_WFEN", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@968 PS1, Line 968: "GPP_D16", "ISH_UART0_CTS#", "n/a", "n/a", "CNV_WCEN", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@969 PS1, Line 969: "GPP_D17", "DMIC_CLK1", "SNDW3_CLK", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@970 PS1, Line 970: "GPP_D18", "DMIC_DATA1", "SNDW3_DATA", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@971 PS1, Line 971: "GPP_D19", "DMIC_CLK0", "SNDW4_CLK", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@972 PS1, Line 972: "GPP_D20", "DMIC_DATA0", "SNDW4_DATA", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@973 PS1, Line 973: "GPP_D21", "SPI1_IO2", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@974 PS1, Line 974: "GPP_D22", "SPI1_IO3", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@975 PS1, Line 975: "GPP_D23", "ISH_I2C2_SCL", "I2C3_SCL", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1046 PS1, Line 1046: "GPP_G0", "SD_CMD", "n/a", "n/a", "n/a", trailing whitespace
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1047 PS1, Line 1047: "GPP_G1", "SD_DATA0", "n/a", "n/a", "n/a", trailing whitespace
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1048 PS1, Line 1048: "GPP_G2", "SD_DATA1", "n/a", "n/a", "n/a", trailing whitespace
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1049 PS1, Line 1049: "GPP_G3", "SD_DATRA2", "n/a", "n/a", "n/a", trailing whitespace
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1050 PS1, Line 1050: "GPP_G4", "SD_DATA3", "n/a", "n/a", "n/a", trailing whitespace
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1051 PS1, Line 1051: "GPP_G5", "SD_CD#", "n/a", "n/a", "n/a", trailing whitespace
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1052 PS1, Line 1052: "GPP_G6", "SD_CLK", "n/a", "n/a", "n/a", trailing whitespace
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1053 PS1, Line 1053: "GPP_G7", "SD_WP", "n/a", "n/a", "n/a", trailing whitespace
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1126 PS1, Line 1126: "GPP_J0", "CNV_PA_BLANKING", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1127 PS1, Line 1127: "GPP_J1", "n/a", "CPU_C10_GATE#", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1128 PS1, Line 1128: "GPP_J2", "n/a", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1129 PS1, Line 1129: "GPP_J3", "n/a", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1130 PS1, Line 1130: "GPP_J4", "CNV_BRI_DT", "UART0B_RTS#", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1131 PS1, Line 1131: "GPP_J5", "CNV_BRI_RSP", "UART0B_RXD", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1132 PS1, Line 1132: "GPP_J6", "CNV_RGI_DT", "UART0B_TXD", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1133 PS1, Line 1133: "GPP_J7", "CNV_RGI_RSP", "UART0B_CTS#", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1134 PS1, Line 1134: "GPP_J8", "CNV_MFUART2_RXD", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1135 PS1, Line 1135: "GPP_J9", "CNV_MFUART2_TXD", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1136 PS1, Line 1136: "GPP_J10", "n/a", "n/a", "n/a", "n/a", line over 80 characters
https://review.coreboot.org/#/c/31501/1/util/inteltool/gpio_groups.c@1137 PS1, Line 1137: "GPP_J11", "A4WP_PRESENT", "n/a", "n/a", "n/a", line over 80 characters