Attention is currently required from: Jack Rosenthal.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59714 )
Change subject: util/cbfstool: Port elogtool to libflashrom
......................................................................
Patch Set 3:
(2 comments)
This change is ready for review.
File util/cbfstool/elogtool.c:
https://review.coreboot.org/c/coreboot/+/59714/comment/bd9b845c_5f3415f2
PS2, Line 116: };
blank line required after declaration
Done
File util/cbfstool/uflashrom.c:
https://review.coreboot.org/c/coreboot/+/59714/comment/1dc8ff1a_b1a94249
PS2, Line 65: // XXX
?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59714
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79df2934b9b0492a554a4fecdd533a0abe1df231
Gerrit-Change-Number: 59714
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jack Rosenthal
jrosenth@chromium.org
Gerrit-CC: Jack Rosenthal
jrosenth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sam McNally
sammc@google.com
Gerrit-Attention: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Comment-Date: Tue, 21 Dec 2021 08:04:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jack Rosenthal
jrosenth@chromium.org
Gerrit-MessageType: comment