HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45554 )
Change subject: mb/getac/p470/acpi: Convert 'battery.asl' to ASL 2.0 syntax
......................................................................
Patch Set 7:
Patch Set 7: Code-Review+1
I think this looks correct.
I think this overall ASL 2 conversion is a fantastic idea!
But it's also amenable to automation...
If I take a quick look in the coreboot source tree, I see:
`git grep -c Store -- *.asl | wc -l`
327 .asl files that could use conversion to the new syntax.
Food for thought 😊
Honestly I have no idea how to make an automation.
'iasl -ca' cmd will not work.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45554
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcc8bf4022838056bf1fff853eb2027af684064e
Gerrit-Change-Number: 45554
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 02 Oct 2020 05:22:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment