Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83662?usp=email )
Change subject: mb/google/brox/variants/brox: remove PL4 value modification ......................................................................
mb/google/brox/variants/brox: remove PL4 value modification
Remove PL4 value modification based on PsysPL3 value.
BUG=None BRANCH=None TEST=Built and boot on brox system
Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com Change-Id: Ic7fbc6386769aa9f76a8665a742c97dfd790fd1d Reviewed-on: https://review.coreboot.org/c/coreboot/+/83662 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Sowmya Aralguppe sowmya.aralguppe@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai ericllai@google.com --- M src/mainboard/google/brox/variants/baseboard/brox/ramstage.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: Sowmya Aralguppe: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved build bot (Jenkins): Verified Eric Lai: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/brox/variants/baseboard/brox/ramstage.c b/src/mainboard/google/brox/variants/baseboard/brox/ramstage.c index be1ba08..038255f 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/ramstage.c +++ b/src/mainboard/google/brox/variants/baseboard/brox/ramstage.c @@ -156,10 +156,6 @@ /* Limit PL2 if the adapter is with lower capability */ pl2 = (psyspl2 > pl2_default) ? pl2_default : SET_PL2(config_psys->efficiency, watts);
- /* If PL4 > psyspl3, lower it */ - if (soc_config->tdp_pl4 > psyspl3) - soc_config->tdp_pl4 = psyspl3; - /* now that we're done calculating, set everything */ soc_config->tdp_pl2_override = pl2; soc_config->tdp_psyspl2 = psyspl2;