24 Apr
2022
24 Apr
'22
8:45 p.m.
Attention is currently required from: Raul Rangel, Eric Lai, Karthik Ramasubramanian. Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63739 )
Change subject: mb/google/skyrim: Configure SD_AUX_RESET_L signal ......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/63739/comment/fa9b7275_c5a25d0e PS5, Line 189: /* SD_AUX_RESET_L */ : PAD_GPO(GPIO_27, LOW),
I think this pin will always get reset, so no need to add it here.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/63739
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03d88d90acc03cdebcb1e83ed2e799dda8b5b735
Gerrit-Change-Number: 63739
Gerrit-PatchSet: 6
Gerrit-Owner: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Amanda Hwang amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Mon, 25 Apr 2022 03:45:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Gerrit-MessageType: comment