build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34537 )
Change subject: src/device/oprom: Fix bootsplash display code for optionroms ......................................................................
Patch Set 13:
(6 comments)
https://review.coreboot.org/c/coreboot/+/34537/13/src/device/oprom/realmode/... File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/34537/13/src/device/oprom/realmode/... PS13, Line 349: unsigned char *framebuffer = trailing whitespace
https://review.coreboot.org/c/coreboot/+/34537/13/src/device/oprom/realmode/... PS13, Line 355: printk(BIOS_DEBUG, "VBE: framebuffer: %p\n" ,framebuffer); space prohibited before that ',' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/34537/13/src/device/oprom/realmode/... PS13, Line 355: printk(BIOS_DEBUG, "VBE: framebuffer: %p\n" ,framebuffer); space required after that ',' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/34537/13/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/34537/13/src/device/pci_device.c@77... PS13, Line 773: if(vbe_mode_info_valid()){ space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/34537/13/src/device/pci_device.c@77... PS13, Line 773: if(vbe_mode_info_valid()){ space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/34537/13/src/device/pci_device.c@77... PS13, Line 778: unsigned char *framebuffer = (unsigned char *)le32_to_cpu(mode_info.vesa.phys_base_ptr); line over 96 characters