Attention is currently required from: Paul Menzel, Sean Rhodes.
Felix Singer has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83265?usp=email )
Change subject: soc/intel/common: Add fpt_support to override CSME and HECI disables
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Wouldn't it be better to document what the ME and the HECI interface can be / is used for instead of introducing an option which overrides another option? I feel that's quite confusing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83265?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I695fa96c5057303730492139904dfcc1d989880b
Gerrit-Change-Number: 83265
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 02 Jul 2024 19:55:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No