Attention is currently required from: Maximilian Brune, Philipp Hug, ron minnich.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81909?usp=email )
Change subject: soc/sifive/fu540/chip.c: Add RAM resources
......................................................................
Patch Set 1:
(1 comment)
File src/soc/sifive/fu540/chip.c:
https://review.coreboot.org/c/coreboot/+/81909/comment/91b99c5a_0a016481 :
PS1, Line 15: .enable_dev
Having this on a read_resource device ops is more appropriate.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81909?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id07eae3560ce69cd8a6a695702fa0b4463c50855
Gerrit-Change-Number: 81909
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 16 Apr 2024 11:02:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment