Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5504
-gerrit
commit 6bb5d97dcc09fa939ca4c38d9dec31f4cb0eda13 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Tue Apr 15 14:32:53 2014 +1000
driver/elog: Fix implicit function declaration issue
Fix compilation. Relying on the pre-processor to condition a if statement will lead to warnings of implicititly defined functions. Also, fix header with prototype for boot_count_read().
Change-Id: Id0117528c5579cc1dec750a8a17a76fab4314b3f Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/drivers/elog/elog.c | 5 +++-- src/drivers/elog/elog_internal.h | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c index de34928..dafd04d 100644 --- a/src/drivers/elog/elog.c +++ b/src/drivers/elog/elog.c @@ -611,8 +611,9 @@ int elog_init(void) elog_add_event_dword(ELOG_TYPE_BOOT, boot_count_read());
/* Check and log POST codes from previous boot */ - if (CONFIG_CMOS_POST) - cmos_post_log(); +#if CONFIG_CMOS_POST == 1 + cmos_post_log(); +#endif /* CONFIG_CMOS_POST */ #endif
return 0; diff --git a/src/drivers/elog/elog_internal.h b/src/drivers/elog/elog_internal.h index dd28231..76561cd 100644 --- a/src/drivers/elog/elog_internal.h +++ b/src/drivers/elog/elog_internal.h @@ -68,4 +68,6 @@ struct elog_area { u8 data[0]; } __attribute__((packed));
+u32 boot_count_read(void); + #endif /* ELOG_INTERNAL_H_ */