Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Marshall Dawson, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47483
to look at the new patch set (#2).
Change subject: [WIP] soc/amd/common: factor out SMU code from Picasso ......................................................................
[WIP] soc/amd/common: factor out SMU code from Picasso
The SMU mailbox access code from Picasso can be reused in the next generation, so factor out the code to soc/amd/common/block/smu.
The message ID argument of the send_smu_message function is changed from the SoC specific smu_message_id enum to an uint32_t to avoid including the SoC-specific header file in the common SMU header file.
The patch is still untested on google/zork.
Change-Id: Ibaf5b91ab35428e4c771e7163c6e0c4fc50371e7 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- A src/soc/amd/common/block/include/amdblocks/smu.h A src/soc/amd/common/block/smu/Kconfig A src/soc/amd/common/block/smu/Makefile.inc A src/soc/amd/common/block/smu/smu.c M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/include/soc/smu.h M src/soc/amd/picasso/smu.c 7 files changed, 122 insertions(+), 99 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/47483/2