build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43764 )
Change subject: mb/google/volteer/variants/volteer: Add gpio-keys ACPI node for PENH ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43764/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/gpio.c:
https://review.coreboot.org/c/coreboot/+/43764/1/src/mainboard/google/voltee... PS1, Line 33: PAD_CFG_GPI_GPIO_DRIVER(GPP_B3, NONE, PLTRST), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/43764/1/src/mainboard/google/voltee... PS1, Line 33: PAD_CFG_GPI_GPIO_DRIVER(GPP_B3, NONE, PLTRST), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43764/1/src/mainboard/google/voltee... PS1, Line 101: PAD_CFG_GPI_SCI(GPP_E1, NONE, DEEP, EDGE_SINGLE, NONE), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/43764/1/src/mainboard/google/voltee... PS1, Line 101: PAD_CFG_GPI_SCI(GPP_E1, NONE, DEEP, EDGE_SINGLE, NONE), please, no spaces at the start of a line