Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60317 )
Change subject: soc/mediatek/mt8186: Add devapc basic drivers ......................................................................
Patch Set 5:
(4 comments)
File src/soc/mediatek/mt8186/devapc.c:
https://review.coreboot.org/c/coreboot/+/60317/comment/62bdb580_491d4844 PS5, Line 6: static const struct apc_infra_peri_dom_8 infra_ao_sys0_devices[] = { How did you create this? Copied from datasheet?
https://review.coreboot.org/c/coreboot/+/60317/comment/70c2efc1_cdf2e67a PS5, Line 1252: int unsigned int
https://review.coreboot.org/c/coreboot/+/60317/comment/711c9079_c5da169a PS5, Line 1306: int unsigned int
File src/soc/mediatek/mt8186/include/soc/devapc.h:
https://review.coreboot.org/c/coreboot/+/60317/comment/3ba7b369_887c5f3d PS5, Line 17: AO_APC_CON = 0x0F00, Please add the datasheet name, revision and section, where you got the offsets from.