[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/meteorlake: Enable VMX

[Paul Menzel (Code Review)]

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Ivy Jian, Eric Lai, Ronak Kanabar.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74161 )

Change subject: soc/intel/meteorlake: Enable VMX
......................................................................

Patch Set 3:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/74161/comment/b46bde7d_57a60546 
PS3, Line 7: soc/intel/meteorlake: Enable VMX
Yes, reading the commit messages of all the change-sets, it’s clear. Commit messages should be self-contained, and only reading this commit message leaves a lot of questions open. Maybe:
> soc/intel/meteorlake: Enable VMX in coreboot if not done by FSP

https://review.coreboot.org/c/coreboot/+/74161/comment/833d74f7_b32e4a52 
PS3, Line 9: This function calls into `set_feature_ctrl_vmx_arg()`
           : to enable VMX for virtualization.
This should also be elaborated.

https://review.coreboot.org/c/coreboot/+/74161/comment/4d5c7ad0_f381cc1d 
PS3, Line 11:
> > I think it was discussed in the past, that coreboot does not need to do it, but it looks like ther […]

I think I was remembering the commit message of commit 305b19dd7a83 (Remove code that enables/disables VMX in coreboot on chromebooks.) [1].

[1]: https://review.coreboot.org/c/coreboot/+/1276