Stefan Reinauer (stefan.reinauer@coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9476
-gerrit
commit da6db734a7aaee44ce7c8a40325e061a4e3630b2 Author: Duncan Laurie dlaurie@chromium.org Date: Sun Nov 23 17:07:50 2014 -0800
tpm: Remove error message for unknown resource type
This is being triggered because the base address is added, but there is nothing that needs done with it in set_resources step and the ERROR message is tripping suspend resume test scripts.
BUG=chrome-os-partner:33385 BRANCH=samus,auron TEST=boot on samus and check for ERROR strings, successfully run suspend_stress_test without failures
Signed-off-by: Duncan Laurie dlaurie@chromium.org Reviewed-on: https://chromium-review.googlesource.com/231603 (cherry picked from commit bb789492965d92e309a913dc7b9f09f7036c5480) Signed-off-by: Duncan Laurie dlaurie@chromium.org
Change-Id: I565c8af954f1c5a406d2c65f01c274e9259e43ec Signed-off-by: Stefan Reinauer reinauer@chromium.org Original-Commit-Id: 9062734d884f814dc880589ee615b4d7e1fdc61a Original-Change-Id: I2b5f44795f1ee445d509b29bd56f498aea7b7fe3 Original-Reviewed-on: https://chromium-review.googlesource.com/231604 Original-Commit-Queue: Duncan Laurie dlaurie@chromium.org Original-Tested-by: Duncan Laurie dlaurie@chromium.org Original-Reviewed-by: Aaron Durbin adurbin@chromium.org --- src/drivers/pc80/tpm/tpm.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/src/drivers/pc80/tpm/tpm.c b/src/drivers/pc80/tpm/tpm.c index f1c5d97..68758aa 100644 --- a/src/drivers/pc80/tpm/tpm.c +++ b/src/drivers/pc80/tpm/tpm.c @@ -749,9 +749,6 @@ static void lpc_tpm_set_resources(struct device *dev) tis_setup_interrupt((int)res->base, config->irq_polarity); } else { - printk(BIOS_ERR, - "ERROR: %s %02lx unknown resource type\n", - dev_path(dev), res->index); continue; }