Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 18: select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY : select BOOT_DEVICE_SUPPORTS_WRITES
Well, it is needed for thew VBOOT setup to work properly. […]
I wonder why this is needed here as SOUTHBRIDGE_INTEL_COMMON_SPI selects BOOT_DEVICE_SUPPORTS_WRITES and I don't see BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY used anywhere.
The SOC Kconfig would be a more appropriate place I think.
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 32: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/mc_bdx1.fmd" You could make this depend on "if VBOOT". This would allow the default fmap to be used in a non VBOOT setup with debugging options like spi flash console which needs a separate fmap.