Attention is currently required from: V Sowmya, Kedar J. Karanje, Furquan Shaikh, vagdevi.p@intel.com, Tim Wawrzynczak, Subrata Banik, Vinay Kumar, Balaji Manigandan, Ronak Kanabar, Patrick Rudolph, Baieswara Reddy Sagili.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56325 )
Change subject: soc/intel/alderlake: Configure the SKU specific parameters for VR domains
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/alderlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/56325/comment/f954ae2f_852771ce
PS7, Line 75: { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, VR_CFG_ALL_DOMAINS_TDC_CURRENT(57, 57) },
: { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, VR_CFG_ALL_DOMAINS_TDC_CURRENT(40, 40) },
: { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, VR_CFG_ALL_DOMAINS_TDC_CURRENT(20, 20) },
: };
these settings look so different than the setting in fsp mCpuVrOverrideTable
may i learn where it from? from vrtt report?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56325
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I434fd30b5bce3bfab5a5800a30317aaa04d9926a
Gerrit-Change-Number: 56325
Gerrit-PatchSet: 7
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Baieswara Reddy Sagili
baieswara.reddy.sagili@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kedar J. Karanje
kedar.j.karanje@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: vagdevi.p@intel.com
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Kedar J. Karanje
kedar.j.karanje@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: vagdevi.p@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Baieswara Reddy Sagili
baieswara.reddy.sagili@intel.com
Gerrit-Comment-Date: Thu, 15 Jul 2021 15:53:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment