Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39907 )
Change subject: superio/winbond/{w83627hf,w83977tf}: Use macro ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patch Set 2:
Patch Set 2:
Have you checked that this does not change the resulting binary?
make BUILD_TIMELESS=1 gives :
*snip*
(looks like w83627hf isn't used ... yet? )
The new patchset might change the binary, but it's the right thing to do.
https://review.coreboot.org/c/coreboot/+/39907/3/src/superio/winbond/w83627h... File src/superio/winbond/w83627hf/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/39907/3/src/superio/winbond/w83627h... PS3, Line 142: /* Announce the used I/O ports to the OS */ Maybe move it to the previous line