Attention is currently required from: Martin L Roth, Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72769 )
Change subject: mb/google/skyrim: Disable unused SPI ROM types ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/skyrim/Kconfig:
https://review.coreboot.org/c/coreboot/+/72769/comment/ee2814cf_e876f541 PS3, Line 206: # Gigadevice is used on Whiterun as an alternative to Winbond : config SPI_FLASH_GIGADEVICE : default y : : # XMC chips used on Markarth as an alternative to Winbond : # These chips identify as ST Micro (Manufacturer ID: 0x20) : config SPI_FLASH_STMICRO : default y
`skyrim/Kconfig.name` is already being used for device-specific values. For example: […]
I have converted most of the Google mainboards at the end of 2021 so that selects are done in Kconfig instead of Kconfig.name, which makes them compliant with the rest of the tree. Only some ARM based mainboards were left because their Kconfig had some other issues which blocked this effort.
Looking at mb/google, these mainboards use selects in Kconfig.name: * asurada * brya (x86) * cherry * corsola * dedede (x86) * geralt * gru * guybrush (x86) * herobrine * kahlee (x86) * kukui * rex (x86) * skyrim (x86) * trogdor * veyron * zork (x86)
I marked the x86 based mainboards which were added in the meantime and use selects in Kconfig.name. All the other ones are ARM based. So the majority of the Google mainboards don't use selects in Kconfig.name anymore.