Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32291 )
Change subject: nb/via/vx900: Ensure memory size and base are in range
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32291/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/32291/1//COMMIT_MSG@9
PS1, Line 9: The bit operations are currently done using 32 bit math.
: Cast the first argument to 64 bits to prevent possible
: overflow.
That's how I understand Arthur, and I agree. […]
I added the check, but did it after the bit shifts to keep things simple.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32291
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd180f31e8cff797a6499b12bc685daa993aae05
Gerrit-Change-Number: 32291
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 20 Aug 2019 16:54:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment