build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35226 )
Change subject: src/soc/intel/common/block/cse: Add helper functions to CSE lib ......................................................................
Patch Set 1:
(81 comments)
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 77: u32 data; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 77: u32 data; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 78: struct { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 78: struct { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 79: u32 working_state: 4; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 79: u32 working_state: 4; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 80: u32 mfg_mode: 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 80: u32 mfg_mode: 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 81: u32 fpt_bad: 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 81: u32 fpt_bad: 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 82: u32 operation_state: 3; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 82: u32 operation_state: 3; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 83: u32 fw_init_complete: 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 83: u32 fw_init_complete: 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 84: u32 ft_bup_ld_flr: 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 84: u32 ft_bup_ld_flr: 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 85: u32 update_in_progress: 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 85: u32 update_in_progress: 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 86: u32 error_code: 4; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 86: u32 error_code: 4; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 87: u32 operation_mode: 4; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 87: u32 operation_mode: 4; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 88: u32 reset_count: 4; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 88: u32 reset_count: 4; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 89: u32 boot_options_present: 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 89: u32 boot_options_present: 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 90: u32 reserved1: 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 90: u32 reserved1: 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 91: u32 bist_test_state: 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 91: u32 bist_test_state: 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 92: u32 bist_reset_request: 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 92: u32 bist_reset_request: 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 93: u32 current_power_source: 2; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 93: u32 current_power_source: 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 94: u32 d3_support_valid: 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 94: u32 d3_support_valid: 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 95: u32 d0i3_support_valid: 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 95: u32 d0i3_support_valid: 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 96: } __packed fields; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 96: } __packed fields; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 269: union me_hfs hfs; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 269: union me_hfs hfs; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 270: hfs.data = me_read_config32(PCI_ME_HFSTS1); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 270: hfs.data = me_read_config32(PCI_ME_HFSTS1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 271: if(hfs.fields.operation_mode == HECI_OP_MODE_SEC_OVERRIDE) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 271: if(hfs.fields.operation_mode == HECI_OP_MODE_SEC_OVERRIDE) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 271: if(hfs.fields.operation_mode == HECI_OP_MODE_SEC_OVERRIDE) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 272: return 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 272: return 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 273: else code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 273: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 274: return 0; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 274: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 279: uint32_t csr; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 279: uint32_t csr; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 280: csr = read_host_csr(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 280: csr = read_host_csr(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 281: csr &= ~CSR_RESET; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 281: csr &= ~CSR_RESET; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 282: csr |= CSR_IG; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 282: csr |= CSR_IG; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 283: csr |= CSR_READY; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 283: csr |= CSR_READY; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 284: write_host_csr(csr); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 284: write_host_csr(csr); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 289: struct stopwatch sw; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 289: struct stopwatch sw; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 291: stopwatch_init_msecs_expire(&sw, 15000); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 291: stopwatch_init_msecs_expire(&sw, 15000); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 292: while (!cse_rec()) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 292: while (!cse_rec()) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 293: udelay(100); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 293: udelay(100); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 294: if (stopwatch_expired(&sw)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 294: if (stopwatch_expired(&sw)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 295: return 0; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 295: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 296: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 296: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 298: return 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35226/1/src/soc/intel/common/block/... PS1, Line 298: return 1; please, no spaces at the start of a line