Attention is currently required from: Kun Liu, Paul Menzel, Shelley Chen, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83139?usp=email )
Change subject: lotso: Add hid report address for gt7986u ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/spi/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/83139/comment/b818443f_321613fc?usp... : PS2, Line 151: if (config->hid_report_addr) : acpi_dp_add_integer(dsd, "goodix,hid-report-addr", : config->hid_report_addr); Since you are adding a vendor specific property, add it as follows:
In src/drivers/spi/acpi/chip.h ``` /* Generic properties for exporting device-specific data to the OS */ struct acpi_dp property_list[MAX_GENERIC_PROPERTY_LIST]; int property_count; ```
Replace the code snippet here: ``` /* Add generic property list */ acpi_dp_add_property_list(dsd, config->property_list, config->property_count); ```
And in the mainboard overridetree.cb ``` register "property_count" = "1" register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" register "property_list[0].name" = ""goodix,hid-report-addr"" register "property_list[0].integer" = "0x22c8c" ```
Also split the mainboard change as a separate CL from the driver CL.