Attention is currently required from: Subrata Banik, Kane Chen, Arthur Heymans.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63566 )
Change subject: cpu/x86/mp_init.c: Add wait_finished_mp_run_on_all_cpus
......................................................................
Patch Set 2:
(1 comment)
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/63566/comment/fa425b17_cb608c43
PS2, Line 984: mp_run_on_aps_and_wait_for_complete
i haven't yet tried `mp_run_on_all_aps` passing `false` […]
The `mp_` functions are all "asynchronous" effectively; they ensure that all of the requested APs accept the task before returning, but it does not wait for the APs to finish. The MP init framework has provisions for that when it is required during mp initialization.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63566
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d1d49bca410c821a3ad0347548afc42eb860594
Gerrit-Change-Number: 63566
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 15 Apr 2022 18:14:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-MessageType: comment